Piechart: Implements series override -> hide in area for the legend or tooltip #51297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellee
requested review from
a team,
codeincarnate and
oscarkilhed
and removed request for
a team
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/23724 |
daniellee
added
no-backport
ryantxu
reviewed
Jun 23, 2022
Comment on lines
97
to
102
| const hideFromViz = value.field.custom.hideFrom.viz; | ||
| const hideFromLegend = value.field.custom?.hideFrom?.legend; | ||
|
|
||
| if (hideFromLegend) { | ||
| return undefined; | ||
| } | ||
|
|
There was a problem hiding this comment.
Maybe
Suggested change
| const hideFromViz = value.field.custom.hideFrom.viz; | |
| const hideFromLegend = value.field.custom?.hideFrom?.legend; | |
| if (hideFromLegend) { | |
| return undefined; | |
| } | |
| const hideFrom = (value.field.custom?.hideFrom ?? {}) as HideSeriesConfig; | |
| if (hideFrom.legend) { | |
| return undefined; | |
| } | |
| const hideFromViz = Boolean(hideFrom.viz) |
it has the hideFrom time involved, so a little nicer
There was a problem hiding this comment.
That is nicer. Couldn't commit your suggestion as it was missing the import for HideSeriesConfig - so added it manually.
There was a problem hiding this comment.
Actually ran into a betterer check for your suggestion - it is adding a type assertion:
daniellee
force-pushed
the
49972-piechart-hidefrom
branch
from
9628c9f
to
db66c8e
Compare
daniellee
changed the title
daniellee
changed the title
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/23895 |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/23897 |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/24075 |
ryantxu
approved these changes
Jun 25, 2022
daniellee
changed the title
|
hey guys what version is this live in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Missing functionality in the pie chart panel for the Series override -> Hide in area.
Shows hiding a country first from the legend and then from the multi tooltip.
Which issue(s) this PR fixes:
Fixes #49972
Special notes for your reviewer:
Not sure if there is a way to avoid duplication. There are two places where this series override is implemented already in the PlotLegend and the TooltipPlugin.
I looked at the PlotLegend code for the legend and tried to keep it similar. The tooltip logic is simpler than the TooltipPlugin implementation.