Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geomap: Update with template variable change #52007

Merged
merged 1 commit into from Jul 8, 2022

Conversation

drew08t
Copy link
Contributor

@drew08t drew08t commented Jul 8, 2022

What this PR does / why we need it:
Change in template variable was not updating geomap.

After componentDidUpdate, check for a data change and apply it.

After (placing marks based on longitude template variable):
Jul-08-2022 15-09-11

Which issue(s) this PR fixes:

Fixes #51983

After componentDidUpdate, check for a data change and apply it.

Fixes #51983
@drew08t drew08t added this to the 9.1.0 milestone Jul 8, 2022
@drew08t drew08t added add to changelog no-backport Skip backport of PR labels Jul 8, 2022
@drew08t drew08t marked this pull request as ready for review July 8, 2022 22:13
@drew08t drew08t requested a review from a team July 8, 2022 22:13
@drew08t drew08t changed the title Geomap: update with template variable change Geomap: Update with template variable change Jul 8, 2022
Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great locally, great job! 🔥

@drew08t drew08t merged commit 7e9194e into main Jul 8, 2022
@drew08t drew08t deleted the drew08t/refresh-data-template-variable branch July 8, 2022 22:46
@mgyongyosi mgyongyosi modified the milestone: 9.1.0-beta1 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geomap: refresh data when template variables change
4 participants