Loki: Add hint for pipeline error to query builder #52134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanahuckova
added
type/feature-request
datasource/Loki
add to changelog
no-backport
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/25961 |
joshhunt
reviewed
Jul 13, 2022
svennergr
approved these changes
Jul 13, 2022
ivanahuckova
commented
Jul 13, 2022
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/26024 |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/26041 |
bohandley
pushed a commit
that referenced
this pull request
Jul 14, 2022
* WIP * Update * Add tests * Fix lint/betterer errors * Update public/app/plugins/datasource/loki/addToQuery.ts * Update copy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds hint for when sampled log lines have
__error__label (__error__label is created in loki when parsing error happens) AND query has exactly 1 parser AND there is no__error__label filtering.Which issue(s) this PR fixes:
Part of #51980
Special notes for your reviewer:
To test this, I recommend running tns app:
git clone https://github.com/grafana/tns.gitcd tns/production/docker-compose/docker plugin install grafana/loki-docker-driver:latest --alias loki --grant-all-permissionsdocker-compose up -dAnd then in grafana run query
{compose_project="docker-compose"}in query builder. You might need to temporarily update limitmaxLines: 50,inpublic/app/plugins/datasource/loki/datasource.tsto 100, because of the shape of incoming logs.hints.mov