Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Builder: Fix spelling of "lose" in user visible message #53435

Merged
merged 2 commits into from Aug 9, 2022

Conversation

spazm
Copy link
Contributor

@spazm spazm commented Aug 9, 2022

What this PR does / why we need it:

Fixes spelling/usage of "lose" (verb) from incorrect "loose" (adjective).

Very minor change to two user visible error messages and several comments.

@spazm spazm requested a review from a team as a code owner August 9, 2022 03:04
@CLAassistant
Copy link

CLAassistant commented Aug 9, 2022

CLA assistant check
All committers have signed the CLA.

@grafanabot grafanabot added area/frontend datasource/Prometheus pr/external This PR is from external contributor labels Aug 9, 2022
@spazm spazm requested a review from a team as a code owner August 9, 2022 03:17
@spazm spazm changed the title Prometheus Query Builder: Fix spelling of "lose" in user visible message Query Builder: Fix spelling of "lose" in user visible message Aug 9, 2022
@spazm
Copy link
Contributor Author

spazm commented Aug 9, 2022

found and fixed more instances of incorrect usage. PR summary updated.

@svennergr svennergr added backport v9.1.x Bot will automatically open backport PR add to changelog labels Aug 9, 2022
@ivanahuckova ivanahuckova requested review from matyax and removed request for a team August 9, 2022 08:32
@ivanahuckova ivanahuckova added no-backport Skip backport of PR and removed backport v9.1.x Bot will automatically open backport PR labels Aug 9, 2022
@ivanahuckova ivanahuckova added this to the 9.2.0 milestone Aug 9, 2022
Copy link
Contributor

@matyax matyax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for your contribution!

@matyax matyax closed this Aug 9, 2022
@matyax matyax reopened this Aug 9, 2022
@matyax matyax merged commit 109f821 into grafana:main Aug 9, 2022
@dsotirakis dsotirakis modified the milestones: 9.2.0, 9.2.0-beta1 Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants