InfluxDB: Remove browser ('direct' access) mode. #53529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obetomuniz
added
type/feature-request
datasource/InfluxDB
type/docs
area/frontend
breaking change
obetomuniz
requested review from
jdbaldry and
KMiller-Grafana
and removed request for
a team
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/29494 |
obetomuniz
requested review from
a team and
GrafanaWriter
and removed request for
a team
gtk-grafana
reviewed
Aug 15, 2022
public/app/plugins/datasource/influxdb/components/__snapshots__/ConfigEditor.test.tsx.snap
Show resolved
Hide resolved
gtk-grafana
approved these changes
Aug 16, 2022
There was a problem hiding this comment.
A couple minor copy tweaks, but otherwise this looks really good! Everything works for me locally, and users see a warning message in the datasource configuration when direct browser access is previously configured, and users are unable to reselect browser mode after changing it. Thanks for taking a look at this Beto!
public/app/plugins/datasource/influxdb/components/ConfigEditor.tsx
Outdated
Show resolved
Hide resolved
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/30144 |
* main: (153 commits) Navigation: Improve responsiveness of `TopSearchBar` (#53777) Chore: Remove GetSignedInUserWithCacheCtx from store interface (#53734) Alerting: Improve Mimir AM interoperability with Grafana (#53396) ReleaseNotes: Updated changelog and release notes for 9.1.0 (#53780) Alerting: Support for re-ordering alert rules in a group (#53318) Chore: Remove disable user, disable batch users and searchusers methods from store interface (#53717) codeowners: adjust logs ownership (#53771) Tempo: Fix typo in the tooltip for 'Limit' (#53750) Revert "Analytics: Use Fullstory to get behavioral data (#53732)" (#53762) Release Notes: Add missing report bug fixes (#53597) pkg/web: remove Router and Logger from Context (#53765) fix configuration secret_key relref link (#52742) Docs: Fix link in What's New in 9.1 (#53259) Docs: Add 9.1 to What's New index (#53545) Analytics: Use Fullstory to get behavioral data (#53732) Update dependency eslint to v8.22.0 (#52723) Fix initDashboard bug (#53722) openapi: Use indentations for human-readable JSON (#53707) Build: upgrade Alpine images (#53743) GeoMap: Fix tooltip not showing values (#53738) ...
obetomuniz
changed the title
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/30146 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The changes in this PR are related to the continuous work around the migration to make Access Mode server-side only in InfluxDB.
Screen.Recording.2022-08-10.at.09.47.12.mov
Which issue(s) this PR fixes:
Fixes #47570
Special notes for your reviewer:
Additional insights about other pieces of code that can be deleted or docs that can be updated with this change are welcomed. Also, most of the changes here were inspired by the design of the solution applied in the Elasticsearch Browser ('direct' access) remove task and related work effort. Feel free to any improvement suggestions.
Release notice breaking change
In InfluxDB, browser access mode was deprecated in Grafana 8.0.0 and removed in 9.2.0. If you used this mode, please switch to server access mode on the datasource configuration page.