Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public Dashboards: Add audit table #54508

Merged
merged 43 commits into from Oct 13, 2022
Merged

Public Dashboards: Add audit table #54508

merged 43 commits into from Oct 13, 2022

Conversation

jalevin
Copy link
Contributor

@jalevin jalevin commented Aug 31, 2022 •
edited

This PR adds a table for viewing all public dashboards on an instance of grafana.
image

This is a first pass to get the feature implemented. We will do an additional pass to clean this up and reuse existing components.

https://docs.google.com/document/d/1D9jnhYj1ZtxNHYhDJgDv4i--43qrBjh5KJX7wIdGf1k/edit#heading=h.k7kv6iubst6n

@jalevin jalevin self-assigned this Sep 8, 2022
@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/34831

@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/35802

@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/35979

@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/36635

@jalevin jalevin dismissed juanicabanas’s stale review October 7, 2022 17:36

Made necessary fixed and moved the rest of the requested changes to refactor ticket that is ready for dev

evictorero
evictorero requested changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@evictorero evictorero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works as expected. Can we add pagination to this table?

pkg/services/publicdashboards/database/database.go Show resolved Hide resolved
public/app/features/manage-dashboards/components/PublicDashboardListTable.tsx Outdated Show resolved Hide resolved
public/app/features/manage-dashboards/components/PublicDashboardListTable.tsx Outdated Show resolved Hide resolved
owensmallwood
owensmallwood approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@owensmallwood owensmallwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Only needed change is changing that left join to an inner join

@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/37411

@jalevin
Copy link
Contributor Author

jalevin commented Oct 12, 2022

I tested it and it works as expected. Can we add pagination to this table?

Pagination in v2! I believe the table component will handle this for us

@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/37413

@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/37417

@grafanabot
Copy link
Contributor

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/37427

@jalevin jalevin merged commit cc27214 into main Oct 13, 2022
@jalevin jalevin deleted the jalevin/add_public_dashboard_table branch October 13, 2022 05:36
@leandro-deveikis leandro-deveikis modified the milestones: 9.3.0, 9.3.0-beta1 Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkelo torkelo torkelo left review comments

@juanicabanas juanicabanas juanicabanas approved these changes

@owensmallwood owensmallwood owensmallwood approved these changes

@evictorero evictorero evictorero approved these changes

@mildwonkey mildwonkey Awaiting requested review from mildwonkey mildwonkey was automatically assigned from grafana/backend-platform

@sh0rez sh0rez Awaiting requested review from sh0rez sh0rez was automatically assigned from grafana/backend-platform

@idafurjes idafurjes Awaiting requested review from idafurjes idafurjes was automatically assigned from grafana/backend-platform

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt was automatically assigned from grafana/grafana-frontend-platform

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90 ashharrison90 was automatically assigned from grafana/grafana-frontend-platform

@academo academo Awaiting requested review from academo academo was automatically assigned from grafana/plugins-platform-frontend

@dprokop dprokop Awaiting requested review from dprokop

@zoltanbedi zoltanbedi Awaiting requested review from zoltanbedi

Assignees

@jalevin jalevin

Labels
add to changelog area/backend area/frontend area/public-dashboards enterprise-failed no-backport Skip backport of PR
Projects
None yet
Milestone
9.3.0-beta1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jalevin @grafanabot @owensmallwood @torkelo @juanicabanas @evictorero @leandro-deveikis