Alerting: Change default alert state to Error on execution error or timeout #55345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/33896 |
grobinson-grafana
force-pushed
the
grobinson/change-default-execution-error-or-timeout-state
branch
from
2c3eae6
to
cad66d0
Compare
joeblubaugh
approved these changes
Sep 19, 2022
soniaAguilarPeiron
approved these changes
Sep 19, 2022
| @@ -294,7 +294,7 @@ describe('RuleEditor', () => { | |||
| grafana_alert: { | |||
| condition: 'B', | |||
| data: getDefaultQueries(), | |||
| exec_err_state: 'Alerting', | |||
| exec_err_state: 'Error', | |||
There was a problem hiding this comment.
We should use GrafanaAlertStateDecision.Error instead of 'Error' string
There was a problem hiding this comment.
I think I will leave this to be discussed within the frontend squad as I don't have a good understanding of the RuleEditor.
| @@ -505,7 +505,7 @@ describe('RuleEditor', () => { | |||
| uid, | |||
| condition: 'B', | |||
| data: getDefaultQueries(), | |||
| exec_err_state: 'Alerting', | |||
| exec_err_state: 'Error', | |||
grobinson-grafana
deleted the
grobinson/change-default-execution-error-or-timeout-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request changes the default alert state to Error for Alert state on execution error or timeout.
Which issue(s) this PR fixes:
Fixes #46398
Special notes for your reviewer: