Profiling: Add Phlare and Parca datasources #57809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aocenas
requested review from
leventebalogh,
wbrowne,
marefr,
sakjur,
idafurjes and
yangkb09
and removed request for
a team and
leventebalogh
joey-grafana
approved these changes
Oct 28, 2022
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/39695 |
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/39701 |
tolzhabayev
requested review from
a team,
wbrowne,
marefr and
jackw
and removed request for
a team
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/39715 |
aocenas
changed the title
aocenas
changed the title
2 tasks
grobinson-grafana
pushed a commit
that referenced
this pull request
Oct 31, 2022
* Add phlare datasource * Rename * Add parca * Add self field to parca * Make sure phlare works with add to dashboard flow * Add profiling category and hide behind feature flag * Update description and logos * Update phlare icon * Cleanup logging * Clean up logging * Fix for shift+enter * onRunQuery to set label * Update type naming * Fix lint * Fix test and quality issues Co-authored-by: Joey Tawadrous <joey.tawadrous@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 2 new core datasources for continuous profiling which works with the new Flamegraph visualization.
This was already tested in a private repo so this PR just moves the same code into grafana core.
Special notes for your reviewer:
The datasources are hidden behind a
flameGraphfeature flagParca can be tested with https://demo.parca.dev/ URL
Phlare can be run from https://github.com/grafana/phlare