Folder: Replace folderId with folderUid

[lpskdl]

What is this feature?

Replace folderId with folderUid in the following areas:

• Folder picker in unified alerting
• Returning to view mode after editing a panel
• Folder picker in dashboard general settings
• Saving dashboard
• pre-selecting folder in save dashboard form modal
• uid in routes when opening a dashboard
• saving dashboard json in dashboard settings
• dashboard/folder name validation
• moving dashboard to another folder
• dashboard action buttons
• dashboard creations on an empty folder
• showing library panel
• saving a library panel

Why do we need this feature?

• Prework needed for nested folder feature. Although the backend will still support backward compatibility of using folderId it would be easier to start on cleaner state when we start the actual feature as they will be mostly working with folderUids

Blocked by issue #57988. This is needed to avoid supporting folderId and folderUid in ImportDashboardForm component.

Which issue(s) does this PR fix?:

Fixes #57874

Special notes for your reviewer:

• Import dashboard isn't working at the moment with folderUid it will be solve when api/dashboards/import API isn't working with folderUid #57988 is addressed
• DashList and AlertList are still using folderId as the api to get those list aren't supporting folderUid at the moment. Separate issue will be created for that and be assigned to the backend.

[grafanabot]

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/41310

[soniaAguilarPeiron]

Looks great from alerting side! 🎉

[grafanabot]

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/41968

[kaydelaney]

Would it be possible for this to get merged soon? :)

[lpskdl]

Would it be possible for this to get merged soon? :)

Hi @kaydelaney, I would like to ask if you can have a review on the FolderPicker changes please :) If all good I will merge it

[grafanabot]

This pull request was removed from the 9.3.0-beta1 milestone because 9.3.0-beta1 is currently being released.

[grafanabot]

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42137

[grafanabot]

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42189

[JoaoSilvaGrafana]

Nice one! 👏

[JoaoSilvaGrafana]

Just out of curiosity, which scenarios does folderUid === undefined && folderId === null? is it some sort of legacy thing?

[lpskdl]

Good eyes @JoaoSilvaGrafana it suppose to be folderUid. About the scenario, It seems part of a legacy thing, I'm not entirely sure which scenario it catches as it always go to the second condition(fullDash.meta.folderUid === toFolder.uid).

Probably there might be a case where folderUid is undefined or null and if this happen the same as the destination folder is '' which is general then we assume that they are in the same general folder location hence sending { alreadyInFolder: true };

[grafanabot]

Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42265