Prometheus: Remove raw query toggle #59069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Drone build failed: https://drone.grafana.net/grafana/grafana-enterprise/42733 |
gtk-grafana
added
no-backport
|
@itsmylife this was assigned to you, but I stole it to have a quick win I could work on while jet-lagged. Did I miss anything that you and Diego had discussed? |
itsmylife
approved these changes
Nov 23, 2022
public/app/plugins/datasource/prometheus/querybuilder/components/QueryPreview.tsx
Show resolved
Hide resolved
gtk-grafana
deleted the
gtk-grafana/issues/58626/remove-raw-query-toggle-option
branch
|
As part of G10 Getting started with Prometheus Thanks @gtk-grafana! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR removes the raw query toggle from the Prometheus query builder, and reduces the size/contrast of the raw query section.
Why do we need this feature?
To simplify the query builder. Seeing the raw query is a good way for users to confirm that values selected in the query builder are as expected, even without knowledge of promql, and the ability to hide/remove this section within the query builder is not useful functionality.
Who is this feature for?
First time and existing users of the prometheus query builder.
Which issue(s) does this PR fix?:
Fixes #58626
Special notes for your reviewer:
Can anyone think of a use case where we absolutely don't want to show the raw query text? I guess if people really hate seeing the raw query we could move this configuration to elsewhere in the UI?