Table Panel: Fix image of image cell overflowing table cell and cells ignoring text alignment setting when a data link is added #59392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarkilhed
requested review from
zoltanbedi,
mdvictor,
joshhunt,
JoaoSilvaGrafana and
academo
and removed request for
a team
oscarkilhed
force-pushed
the
oscark/fix-image-link-overflow
branch
from
a278e60
to
0842b20
Compare
oscarkilhed
changed the title
oscarkilhed
changed the title
|
This pull request was removed from the 9.3.0 milestone because 9.3.0 is currently being released. |
zoltanbedi
requested changes
Nov 30, 2022
There was a problem hiding this comment.
I think the issue you opened @oscarkilhed is the same as #57572 can you please instead try to fix that issue. This pr works for the images but not for others.
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
grafanabot
added
pr/external
|
@zoltanbedi this should fix both issues! |
zoltanbedi
approved these changes
Jan 17, 2023
oscarkilhed
changed the title
oscarkilhed
added a commit
that referenced
this pull request
Mar 21, 2023
…when a data link is added. (#61617) Table Panel: Fix image of image cell overflowing table cell when a data link is added. (#59392) * TablePanel: fix image of image cell overflowing table cell when a data link is added * Fix image cell and gauge panel in respective places instead (cherry picked from commit 004705a) Co-authored-by: Oscar Kilhed <oscar.kilhed@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Fixes an issue where the image is overflowing the table cell when a single data link is added.
Also fixes text alignment not working on data link cells.
Reverts #55129 and moves the solution to the gauge panel.
Which issue(s) does this PR fix?:
Fixes #59391
Fixes #57572