-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphite: Fix bug in wildcard queries to Graphite plugin #60549
Conversation
Hello @mmandrus!
Please, if the current pull request addresses a bug fix, label it with the |
@grafana/observability-metrics do you agree that this should be backported? This really only affects public dashboards, but it's still a bug caused by a recent change. |
@mmandrus yeah it's a one line fix with the type/bug label, I'd say that makes it applicable for backport. Go for it! |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-60549-to-v9.3.x origin/v9.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 09c759b36c520c69038dc21b7fdc504df058b0db
# Push it to GitHub
git push --set-upstream origin backport-60549-to-v9.3.x
git switch main
# Remove the local backport branch
git branch -D backport-60549-to-v9.3.x Then, create a pull request where the |
What is this feature?
In this recent PR, the Graphite datasource was refactored to support multiple queries. However, this introduced a bug in wildcard queries due to the fact that it was overwriting results belonging to the same frame instead of appending them. This PR fixes that.
Public dashboard panel with wildcard queries
Why do we need this feature?
In order to make public dashboards accurately reflect what is shown on regular dashboards. Note that this has no bearing on regular dashboards, which query graphite through the datasource proxy endpoint.
Which issue(s) does this PR fix?:
Fixes #60141