Search: Auto focus input elements #61443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ryantxu!
Please, if the current pull request addresses a bug fix, label it with the |
ryantxu
commented
Jan 13, 2023
| @@ -46,6 +46,7 @@ export const ManageDashboardsNew = React.memo(({ folder }: Props) => { | |||
| value={state.query ?? ''} | |||
| onChange={(e) => stateManager.onQueryChange(e.currentTarget.value)} | |||
| onKeyDown={onKeyDown} | |||
| // eslint-disable-next-line jsx-a11y/no-autofocus | |||
There was a problem hiding this comment.
this is the one on the list that seems debateable... but was already autoFocus 馃し
ashharrison90
approved these changes
Jan 13, 2023
| @@ -60,6 +60,8 @@ export function DashboardSearchModal({ isOpen }: Props) { | |||
| tabIndex={0} | |||
| spellCheck={false} | |||
| className={styles.input} | |||
| // eslint-disable-next-line jsx-a11y/no-autofocus | |||
| autoFocus | |||
There was a problem hiding this comment.
this doesn't need autoFocus, it already focuses when the modal is opened.
grafanabot
pushed a commit
that referenced
this pull request
Jan 13, 2023
(cherry picked from commit ce3a96a)
|
Will this make it into the next 9.3.x release? This is a major annoyance for us too |
|
yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59853 and https://github.com/grafana/support-escalations/issues/4793
Removing "autofocus" from everywhere caused the search pages to not let you start typing 馃槵