Alerting: Set error annotation on EvaluationError regardless of underlying error type #61506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Previously we only set the error annotation on a state if the
expr.Result
's attached error is anexpr.QueryError
. This assumes that the expression engine always wraps its error types consistently. If it fails to do so, there is no Error annotation.This PR makes it so we always set the Error annotation for all errors, regardless of its type. This appears to be a bug based on the comment, which intends to just add special fields from
expr.QueryError
likeref_id
/datasource_uid
Which issue(s) does this PR fix?:
n/a
Special notes for your reviewer: