SAML: Support auto login #61685
Merged
SAML: Support auto login #61685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderzobnin
added
area/auth/oauth
area/auth/saml
no-backport
alexanderzobnin
requested review from
torkelo,
a team and
chri2547
as code owners
alexanderzobnin
requested review from
mgyongyosi,
idafurjes,
yangkb09 and
ying-jeanne
and removed request for
a team
mgyongyosi
reviewed
Jan 19, 2023
Jguer
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds support for SAML auto login. Also, it adds support for individual
auto_loginsetting for each OAuth provider. Globaloauth_auto_loginsetting is deprecated, but still working. Logic:oauth_auto_loginsetting is enabled and noauto_loginsettings set, then behave as before.oauth_auto_loginsetting is enabled and any OAuth section hasauto_loginenabled, then ignore auth-specific settings (behave as before).oauth_auto_loginsetting isn't configured, then auth-specificauto_logintakes effect.auto_loginsettings configured, then auto login is skipped with warning.Why do we need this feature?
Auto login feature should be unified across all providers (which support redirect auth).
Special notes for your reviewer: