Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elasticsearch: Fix toggle-settings are not shown correctly #61751

Merged
merged 2 commits into from Jan 19, 2023
Merged

Elasticsearch: Fix toggle-settings are not shown correctly #61751

merged 2 commits into from Jan 19, 2023

Conversation

svennergr
Copy link
Contributor

Why do we need this feature?

As reported in #61665 the toggle settings like X-Pack enabled are not shown correctly in the UI. It seems like the checked property was deprecated and changing it to value seems to fix it.

Which issue(s) does this PR fix?:

Fixes #61665

@svennergr svennergr added this to the 9.3.4 milestone Jan 19, 2023
@svennergr svennergr requested a review from a team as a code owner January 19, 2023 10:45
@svennergr svennergr self-assigned this Jan 19, 2023
@github-actions
Copy link
Contributor

Backend code coverage report for PR #61751
No changes

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #61751

Plugin Main PR Difference
elasticsearch 80.61% 80.61% 0%

@ivanahuckova ivanahuckova requested review from gwdawson and removed request for a team January 19, 2023 11:22
gabor
gabor approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@gabor gabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svennergr svennergr merged commit dd8f95a into main Jan 19, 2023
@svennergr svennergr deleted the svennergr/fix-elastic-settings branch January 19, 2023 11:32
@grafanabot grafanabot mentioned this pull request Jan 19, 2023
Merged
grafanabot pushed a commit that referenced this pull request Jan 19, 2023
@svennergr @grafanabot
Elasticsearch: Fix toggle-settings are not shown correctly (#61751)
256cb9c 
* changed `checked` propery to `value`

* revert changing the prop in the event

(cherry picked from commit dd8f95a)
svennergr added a commit that referenced this pull request Jan 19, 2023
@grafanabot @svennergr
[v9.3.x] Elasticsearch: Fix toggle-settings are not shown correctly (#…
7127d4f 
…61755)

Elasticsearch: Fix toggle-settings are not shown correctly (#61751)

* changed `checked` propery to `value`

* revert changing the prop in the event

(cherry picked from commit dd8f95a)

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
GuYounes pushed a commit to paul-wurth/BIXpert that referenced this pull request Feb 8, 2023
@grafanabot @svennergr @GuaYounesPW
[v9.3.x] Elasticsearch: Fix toggle-settings are not shown correctly (g…
f98b2da 
…rafana#61755)

Elasticsearch: Fix toggle-settings are not shown correctly (grafana#61751)

* changed `checked` propery to `value`

* revert changing the prop in the event

(cherry picked from commit dd8f95a)

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabor gabor gabor approved these changes

@gwdawson gwdawson Awaiting requested review from gwdawson

Assignees

@svennergr svennergr

Labels
add to changelog area/frontend backport v9.3.x datasource/Elasticsearch enterprise-ok type/bug
Projects
None yet
Milestone
9.3.4
Development

Successfully merging this pull request may close these issues.

ElasticSearch Datasources: X-Pack Toggle Button is Broken
3 participants
@svennergr @gabor @grafanabot