Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elasticsearch: Fix failing requests when using SigV4 #61923

Merged
merged 3 commits into from Jan 23, 2023

Conversation

svennergr
Copy link
Contributor

@svennergr svennergr commented Jan 23, 2023

What is this feature?

Backend requests that use SigV4 need to set their servicename before instantiating the HTTPClient. This PR fixes this setting which happened after instantiating the HTTPClient.

Which issue(s) does this PR fix?:

Related to #60614

Copy link
Contributor

@gabor gabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

Backend code coverage report for PR #61923

Plugin Main PR Difference
elasticsearch 87.5% 87.5% 0%

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #61923
No changes

@svennergr svennergr merged commit c561045 into main Jan 23, 2023
@svennergr svennergr deleted the svennergr/fix-elastig-sigv4-issue branch January 23, 2023 15:43
grafanabot pushed a commit that referenced this pull request Jan 23, 2023
fix setting of `es` servicename

(cherry picked from commit c561045)
svennergr added a commit that referenced this pull request Jan 23, 2023
Elasticsearch: Fix failing requests when using SigV4 (#61923)

fix setting of `es` servicename

(cherry picked from commit c561045)

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
baldm0mma pushed a commit that referenced this pull request Jan 26, 2023
GuYounes pushed a commit to paul-wurth/BIXpert that referenced this pull request Feb 8, 2023
…a#61933)

Elasticsearch: Fix failing requests when using SigV4 (grafana#61923)

fix setting of `es` servicename

(cherry picked from commit c561045)

Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants