New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Elasticsearch: Fix failing requests when using SigV4 #61923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Backend code coverage report for PR #61923
|
Frontend code coverage report for PR #61923 |
grafanabot
pushed a commit
that referenced
this pull request
Jan 23, 2023
fix setting of `es` servicename (cherry picked from commit c561045)
svennergr
added a commit
that referenced
this pull request
Jan 23, 2023
baldm0mma
pushed a commit
that referenced
this pull request
Jan 26, 2023
fix setting of `es` servicename
GuYounes
pushed a commit
to paul-wurth/BIXpert
that referenced
this pull request
Feb 8, 2023
…a#61933) Elasticsearch: Fix failing requests when using SigV4 (grafana#61923) fix setting of `es` servicename (cherry picked from commit c561045) Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Backend requests that use SigV4 need to set their servicename before instantiating the HTTPClient. This PR fixes this setting which happened after instantiating the HTTPClient.
Which issue(s) does this PR fix?:
Related to #60614