-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs Panel: Refactor style generation to improve rendering performance #62599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svennergr
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Left a few comments. WDYT about adding the usage of the useStyles2
hook when calling getLogLevelStyles
and getLogRowStyles
?
It's worth mentioning that the measurements and tests for this PR were done in the Explore page. Will follow up with what I see in Dashboards. |
This reverts commit 8487482a6f4fdcf5e26896182c5ad3982774eea2.
Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
Co-authored-by: Sven Grossmann <sven.grossmann@grafana.com>
0adc434
to
6b31fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR refactors how we generate and share styles in logs-related components. The main changes are:
LogsRow
, then pass them as a prop.getLogLevelStyles()
.getStyles()
calls made by children components of aLogRow
have been moved togetLogRowStyles()
.A minor change included in this PR is a
TimeZone
import deprecation fix.Which issue(s) does this PR fix?:
Part of #60687
Part of #63030
Special notes for your reviewer:
The tests for this PR have been performed in the Explore page.
The changes in this branch have been validated using the browser profiler and the React profiler before submission, to ascertain that there was a performance gain from each change. Individual changes have been also ran through the profiler, including a refactor of
LogRow
using functional components which was not included because it had no impact.Avoiding the use of
cx()
and calls togetLogLevelStyles()
have been tested and showed no visible performance improvements.Measurements in the main branch:
Measurements in this feature branch:
The underlying functionality should, obviously, remain intact.