Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs: Rename dedup to deduplicate #62944

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Conversation

gwdawson
Copy link
Member

@gwdawson gwdawson commented Feb 6, 2023

What is this feature?
we think dedup is a technical concept, not an actual word, and doesn't clearly communicate its meaning. this pr updates this word to deduplicate or deduplication

Why do we need this feature?
...

Who is this feature for?
...

Which issue(s) does this PR fix?:
Fixes #62873

Special notes for your reviewer:

@gwdawson gwdawson added add to changelog no-backport Skip backport of PR labels Feb 6, 2023
@gwdawson gwdawson added this to the 9.5.0 milestone Feb 6, 2023
@gwdawson gwdawson requested a review from matyax February 6, 2023 11:48
@gwdawson gwdawson requested review from a team as code owners February 6, 2023 11:48
@gwdawson gwdawson self-assigned this Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Backend code coverage report for PR #62944
No changes

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Frontend code coverage report for PR #62944

Plugin Main PR Difference
explore 86.21% 86.21% 0%

Copy link
Member

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 . Could you also update the name in logs-integration.md documentation?

@gwdawson gwdawson merged commit 8a94688 into main Feb 7, 2023
@gwdawson gwdawson deleted the gareth/rename-deduplication branch February 7, 2023 16:17
jdbaldry pushed a commit that referenced this pull request Feb 24, 2023
* fix: rename dedup with deduplication

* docs: update documentation

* fix: update names

(cherry picked from commit 8a94688)
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
jdbaldry added a commit that referenced this pull request Feb 25, 2023
* [v9.4.x] Logs: Rename dedup to deduplication (#62944)

* fix: rename dedup with deduplication

* docs: update documentation

* fix: update names

(cherry picked from commit 8a94688)
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

* [v9.4.x] fix link to explore with logs and headings (#63665)

fixed links and eadings

(cherry picked from commit a0a2181)
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>

---------

Co-authored-by: Gareth Dawson <gareth.dawson@grafana.com>
Co-authored-by: Isabel <76437239+imatwawana@users.noreply.github.com>
ryantxu pushed a commit that referenced this pull request Mar 2, 2023
* fix: rename dedup with deduplication

* docs: update documentation

* fix: update names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs: Find a better way to communicate the purpose of "Dedup"
4 participants