Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Add optional logger for plugin requests sent to backend plugins #62981

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Plugins: Add optional logger for plugin requests sent to backend plugins #62981

merged 1 commit into from
Feb 7, 2023

Conversation

bergquist
Copy link
Contributor

Turning this into a setting since we have been using it for a while.

@bergquist
plugins: turn feature flag into [plugin] setting
8cb184b 
Signed-off-by: bergquist <carl.bergquist@gmail.com>
@bergquist bergquist added area/instrumentation instrumentation for Grafanas codebase. add to changelog no-backport Skip backport of PR labels Feb 6, 2023
@bergquist bergquist added this to the 9.5.0 milestone Feb 6, 2023
@bergquist bergquist requested a review from marefr February 6, 2023 20:23
@bergquist bergquist changed the title Plugins: turn plugin request logging feature flag into [plugin] setting Plugins: Add optional logger for plugin requests sent to backend plugins Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

⚠️   Possible breaking changes

(Open the links below in a new tab to go to the correct steps)

grafana-data has possible breaking changes (more info)

Console output
Read our guideline

@grafanabot grafanabot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Feb 6, 2023
@bergquist bergquist marked this pull request as ready for review February 7, 2023 09:23
@bergquist bergquist requested review from torkelo and a team as code owners February 7, 2023 09:23
@bergquist bergquist requested a review from a team February 7, 2023 09:23
@bergquist bergquist requested review from a team and chri2547 as code owners February 7, 2023 09:23
@bergquist bergquist requested review from joshhunt, yaelleC, mckn, oscarkilhed, zoltanbedi and wbrowne and removed request for a team February 7, 2023 09:23
@bergquist bergquist requested review from papagian, zserge and mildwonkey and removed request for a team February 7, 2023 09:23
@bergquist
Copy link
Contributor Author

The breaking change is not a problem in this case since this PR only removes a feature flag

papagian
papagian approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@papagian papagian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

marefr
marefr approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@marefr marefr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marefr marefr removed the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Feb 7, 2023
@bergquist bergquist merged commit 2a29a07 into main Feb 7, 2023
@bergquist bergquist deleted the datasource_logging_setting branch February 7, 2023 11:49
ryantxu pushed a commit that referenced this pull request Mar 2, 2023
@bergquist @ryantxu
Plugins: Add optional logger for plugin requests sent to backend plug…
f638be6 
…ins (#62981)

Signed-off-by: bergquist <carl.bergquist@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbrowne wbrowne wbrowne approved these changes

@papagian papagian papagian approved these changes

@marefr marefr marefr approved these changes

@torkelo torkelo Awaiting requested review from torkelo torkelo is a code owner

@chri2547 chri2547 Awaiting requested review from chri2547

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt was automatically assigned from grafana/grafana-frontend-platform

@yaelleC yaelleC Awaiting requested review from yaelleC yaelleC was automatically assigned from grafana/grafana-frontend-platform

@mckn mckn Awaiting requested review from mckn mckn was automatically assigned from grafana/plugins-platform-frontend

@oscarkilhed oscarkilhed Awaiting requested review from oscarkilhed

@zoltanbedi zoltanbedi Awaiting requested review from zoltanbedi

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@mildwonkey mildwonkey Awaiting requested review from mildwonkey mildwonkey was automatically assigned from grafana/backend-platform

Assignees
No one assigned
Labels
add to changelog area/backend area/frontend area/instrumentation instrumentation for Grafanas codebase. no-backport Skip backport of PR type/docs
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bergquist @wbrowne @papagian @marefr @grafanabot