Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Renamed parts of the UI extension APIs #63070

Merged
merged 5 commits into from Feb 8, 2023
Merged

Plugins: Renamed parts of the UI extension APIs #63070

merged 5 commits into from Feb 8, 2023

Conversation

mckn
Copy link
Contributor

@mckn mckn commented Feb 8, 2023 •
edited

What is this feature?
Got some more great feedback after merging #61663 which is address in this PR.

Target -> Placement (to prevent confusion with the href target)
Href -> Path (for consistency)

Why do we need this feature?
Improved readability of the UI extensions feature.

Who is this feature for?
Plugin developers

@mckn mckn added this to the 9.5.0 milestone Feb 8, 2023
@mckn mckn self-assigned this Feb 8, 2023
@mckn mckn marked this pull request as ready for review February 8, 2023 07:12
@mckn mckn requested review from a team as code owners February 8, 2023 07:12
@mckn mckn requested a review from a team February 8, 2023 07:12
@mckn mckn requested review from a team as code owners February 8, 2023 07:12
leventebalogh
leventebalogh approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@leventebalogh leventebalogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

public/app/features/plugins/extensions/registry.ts Show resolved Hide resolved
@mckn mckn added the no-backport Skip backport of PR label Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023 •
edited

⚠️   Possible breaking changes

(Open the links below in a new tab to go to the correct steps)

grafana-runtime has possible breaking changes (more info)

Console output
Read our guideline

@grafanabot grafanabot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Feb 8, 2023
@mckn
Copy link
Contributor Author

mckn commented Feb 8, 2023

⚠️   Possible breaking changes

(Open the links below in a new tab to go to the correct steps)

grafana-runtime has possible breaking changes (more info)

Console output Read our guideline

It is breaking changes compared to main but we have not shipped those in any Grafana version yet since we are targeting 9.5 with this feature.

@mckn mckn removed the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Feb 8, 2023
@grafanabot grafanabot added the levitate breaking change A label indicating a breaking change and assigned by Levitate. label Feb 8, 2023
xnyo
xnyo reviewed Feb 8, 2023
View reviewed changes
Copy link
Member

@xnyo xnyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend changes LGTM but see this comment, I'm not sure if it's possible to address it

pkg/plugins/plugindef/plugindef_types_gen.go Outdated Show resolved Hide resolved
@jackw jackw requested a review from a team as a code owner February 8, 2023 09:24
@mckn mckn enabled auto-merge (squash) February 8, 2023 10:25
@mckn mckn merged commit f46f8bd into main Feb 8, 2023
@mckn mckn deleted the mckn/ui-extensions-2 branch February 8, 2023 10:33
ryantxu pushed a commit that referenced this pull request Mar 2, 2023
@mckn @jackw @ryantxu
Plugins: Renamed parts of the UI extension APIs (#63070)
f9ad8aa 
* Renamed target -> id and href -> path after feedback.

* fixed type issues in test page.

* chore(pluginschemajson): update extensions props target -> id

* this is the final.

* fixed typings...again...

---------

Co-authored-by: Jack Westbrook <jack.westbrook@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marefr marefr marefr left review comments

@leventebalogh leventebalogh leventebalogh approved these changes

@xnyo xnyo xnyo left review comments

@jackw jackw Awaiting requested review from jackw jackw is a code owner automatically assigned from grafana/plugins-platform-frontend

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90 ashharrison90 is a code owner automatically assigned from grafana/grafana-frontend-platform

@JoaoSilvaGrafana JoaoSilvaGrafana Awaiting requested review from JoaoSilvaGrafana JoaoSilvaGrafana is a code owner automatically assigned from grafana/grafana-frontend-platform

@mdvictor mdvictor Awaiting requested review from mdvictor

@baldm0mma baldm0mma Awaiting requested review from baldm0mma

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/plugins-platform-backend

@zserge zserge Awaiting requested review from zserge zserge was automatically assigned from grafana/backend-platform

@mildwonkey mildwonkey Awaiting requested review from mildwonkey mildwonkey was automatically assigned from grafana/backend-platform

@idafurjes idafurjes Awaiting requested review from idafurjes idafurjes was automatically assigned from grafana/backend-platform

@DanCech DanCech Awaiting requested review from DanCech

Assignees

@mckn mckn

Labels
area/backend/plugins area/backend area/frontend area/plugins levitate breaking change A label indicating a breaking change and assigned by Levitate. no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/docs
Projects
Plugins Platform
Archived in project
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mckn @marefr @leventebalogh @xnyo @grafanabot @jackw