Plugin: Skip preloading disabled app plugins #63083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckn
added
area/plugins
area/backend/plugins
area/frontend
add to changelog
area/plugins/app
mckn
requested review from
sakjur,
mildwonkey,
ying-jeanne,
torkelo,
ryantxu and
marefr
and removed request for
a team
torkelo
approved these changes
Feb 8, 2023
ryantxu
pushed a commit
that referenced
this pull request
Mar 2, 2023
will not preload app plugins that is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR will prevent app plugins from being preloaded if they are disabled. Something that we realized while working on the #61663 but didn't want to do it within the same PR.
Why do we need this feature?
Preloading disabled plugins will only slow down the initial load of Grafana.
Who is this feature for?
End users and plugin developers
Special notes for your reviewer:
The frontend will only preload app plugins with the
preload: truevalue passed in the grafana settings. In this PR we will only returnpreload: trueif the app plugin is enabled and haspreload: truespecified in plugin.json.