Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for external server for serving the static assets #6311

Closed
wants to merge 3 commits into from
Closed

add support for external server for serving the static assets #6311

wants to merge 3 commits into from

Commits on Oct 18, 2016

  1. add support for external server for serving the static assets 

    There is still the need to setup CORS in the static server as system.js is fetching
the scripts via xhr.

Using scriptLoad: true will not work here (yet) as it needs to have much more metadata.
    @tardyp
    tardyp committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    099e345 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2016

  1. Review comment fixes 

    - remove setup of static_url in system.conf.js
  after discussion, this is not straightforward to load the plugins from a static server
- remove references to CORS.
  As system.js will not load anything anymore in production mode, there is no need to setup cors.
- mention that the plugins are still served by the main server
- refactor the setting code to parse static_url apart from the AppUrl
    @tardyp
    tardyp committed Oct 20, 2016
    Configuration menu
    Copy the full SHA
    52c7ccc View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2016

  1. Update setting.go

    @tardyp
    tardyp committed Oct 21, 2016
    Configuration menu
    Copy the full SHA
    1a0ddf2 View commit details
    Browse the repository at this point in the history