Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Add dashboard and panel links to rule and instance annotations #63243

Merged
merged 4 commits into from
Feb 22, 2023

Conversation

konrad147
Copy link
Contributor

@konrad147 konrad147 commented Feb 10, 2023

What is this feature?
This feature adds links to a panel and a dashboard associated with the alert rule

Why do we need this feature?
To easily go from an alert rule to an associated panel/dashboard

Fixes #63563

Alert list panel
image

Alert rules list
image

@konrad147 konrad147 added this to the 9.5.0 milestone Feb 10, 2023
@konrad147 konrad147 requested a review from a team February 10, 2023 09:40
@konrad147 konrad147 self-assigned this Feb 10, 2023
Copy link
Member

@soniaAguilarPeiron soniaAguilarPeiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!🎉
I would update the PR description saying that fixes partially the issue. (We also want to create the link from the panel to the alert view )

@@ -30,7 +31,7 @@ export const RuleDetails: FC<Props> = ({ rule }) => {
namespace: { rulesSource },
} = rule;

const annotations = Object.entries(rule.annotations).filter(([_, value]) => !!value.trim());
const annotations = useCleanAnnotations(rule.annotations);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@konrad147 konrad147 merged commit 0a73ac3 into main Feb 22, 2023
@konrad147 konrad147 deleted the alerting/60713-add-dashboard-and-panel-link branch February 22, 2023 12:17
ryantxu pushed a commit that referenced this pull request Mar 2, 2023
…ons (#63243)

* Add dashboard and panel links in rule and instance annotations

* Use clean annotations in RuleViewer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add dashboard and panel links to the alert rule
3 participants