Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: Enable preview for recording rules #63260

Merged
merged 19 commits into from
Mar 22, 2023
Merged

Alerting: Enable preview for recording rules #63260

merged 19 commits into from
Mar 22, 2023

Commits on Mar 6, 2023

  1. Create RecordingRuleEditor component 

    It reuses QueryEditor and propagates a few properties to allow to filter the visible datasources and customize what's shown in the editor header
    @VikaCep
    VikaCep committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    d881a91 View commit details
    Browse the repository at this point in the history

  2. Set recording rules queries as a new state prop 

    Otherwise it would get mixed up with the alert rules queries when switching back and forth from this option. This also allows me to initialize these queries with the right datasource
    @VikaCep
    VikaCep committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    b9e2813 View commit details
    Browse the repository at this point in the history

  3. Show CloudRulesSourcePicker only for Loki/Mimir rules 

    As now we use the query editor for recording rules which already includes a datasource picker within
    @VikaCep
    VikaCep committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    212b415 View commit details
    Browse the repository at this point in the history

  4. Fix lint and tests

    @VikaCep
    VikaCep committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    0a1ae0c View commit details
    Browse the repository at this point in the history

  5. Fix saving a recording rule

    @VikaCep
    VikaCep committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    3fc3188 View commit details
    Browse the repository at this point in the history

  6. Show expression when editing the recording rule

    @VikaCep
    VikaCep committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    47fdc0d View commit details
    Browse the repository at this point in the history

  7. Show query editor back for cloud rules

    @VikaCep
    VikaCep committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    20696b7 View commit details
    Browse the repository at this point in the history

  8. Fix duplicated import

    @VikaCep
    VikaCep committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    491bd33 View commit details
    Browse the repository at this point in the history

  9. Tweak after rebase

    @VikaCep
    VikaCep committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    158e721 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Remove ts-ignore

    @VikaCep
    VikaCep committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    3969fc8 View commit details
    Browse the repository at this point in the history

  2. Refactor to use queries state instead of recordingRuleQueries

    @VikaCep
    VikaCep committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    ca9107a View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. Merge remote-tracking branch 'origin/main' into alerting/enable-previ… 

    …ew-for-recording-rules
    @VikaCep
    VikaCep committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    553baf9 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into alerting/enable-previ… 

    …ew-for-recording-rules
    @VikaCep
    VikaCep committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    cd19a64 View commit details
    Browse the repository at this point in the history

  3. Refacrtor RecordingRuleEditor to use ds QueryEditor

    @VikaCep
    VikaCep committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    a47b2f4 View commit details
    Browse the repository at this point in the history

  4. Revert extra properties previously added to QueryEditor components

    @VikaCep
    VikaCep committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    cdb533f View commit details
    Browse the repository at this point in the history

  5. Remove console.log

    @VikaCep
    VikaCep committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    f7354ba View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. Fix saving/editing a recording rule

    @VikaCep
    VikaCep committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    9baaf6b View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Fix tests

    @VikaCep
    VikaCep committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1a41e40 View commit details
    Browse the repository at this point in the history

  2. Add margin to vizwrapper component

    @VikaCep
    VikaCep committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    bec0277 View commit details
    Browse the repository at this point in the history