Geomap: Fix route layer zoom behavior #63409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew08t
added
no-backport
nmarrs
added
add to changelog
and removed
no-changelog
nmarrs
changed the title
nmarrs
reviewed
Feb 21, 2023
| if (deltaX > 2 || deltaY > 2) { | ||
| flowStyle.setGeometry(LS); | ||
| styles.push(flowStyle); | ||
| j = i + 1; |
There was a problem hiding this comment.
This logic is a little hard for me to follow / understand, what index is j tracking? Are we basically determining at what resolution it is necessary to draw a line vs a single point or?
This logic may be clearer if we broke it out into a util func with a few unit tests for good measure 😃
There was a problem hiding this comment.
Great suggestion, will pull it out and try to simplify!
|
Backend code coverage report for PR #63409
|
|
Frontend code coverage report for PR #63409 |
nmarrs
reviewed
Feb 24, 2023
| @@ -117,6 +117,25 @@ export const getNextLayerName = (panel: GeomapPanel) => { | |||
| return `Layer ${Date.now()}`; | |||
| }; | |||
|
|
|||
| export function isSegmentVisible( | |||
There was a problem hiding this comment.
Great job on this refactor! I think just adding a few unit tests for this util function would be good 👍
baldm0mma
pushed a commit
that referenced
this pull request
Mar 6, 2023
* Geomap: Fix Zoom Bug * Add handling for case where no segments created * Simplify segment checks and pull logic into utils * Rename pixel variables * Roll back change to raw data response json
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Currently route layer has unusual rendering behavior when zooming. This occurs when segments are small enough to share a pixel and are not rendered.
Before:
After (1000 point route layer):
Closes #63323