Feat: Linking to plugin details page rather than externally for new datasources #63499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to be installed directly
tolzhabayev
changed the title
tolzhabayev
requested review from
joshhunt,
JoaoSilvaGrafana and
jackw
and removed request for
a team
tolzhabayev
commented
Feb 21, 2023
| @@ -244,8 +244,9 @@ function getPhantomPlugin(options: GetPhantomPluginOptions): DataSourcePluginMet | |||
| author: { name: 'Grafana Labs' }, | |||
| links: [ | |||
| { | |||
| url: config.pluginCatalogURL + options.id, | |||
| url: '/plugins/' + options.id, | |||
There was a problem hiding this comment.
I am not quite sure if there is a better / stable way to import this route from somewhere as obviously if it changes this will break
There was a problem hiding this comment.
I am afraid we don't have these extracted to a const yet (they are defined here as well).
Probably a good candidate for refactoring in a separate PR!
tolzhabayev
commented
Feb 21, 2023
public/app/features/datasources/components/DataSourceTypeCard.tsx
Outdated
Show resolved
Hide resolved
|
fyi @mjseaman |
| @@ -244,8 +244,9 @@ function getPhantomPlugin(options: GetPhantomPluginOptions): DataSourcePluginMet | |||
| author: { name: 'Grafana Labs' }, | |||
| links: [ | |||
| { | |||
| url: config.pluginCatalogURL + options.id, | |||
| url: '/plugins/' + options.id, | |||
There was a problem hiding this comment.
I am afraid we don't have these extracted to a const yet (they are defined here as well).
Probably a good candidate for refactoring in a separate PR!
public/app/features/datasources/components/DataSourceTypeCard.tsx
Outdated
Show resolved
Hide resolved
leventebalogh
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This changes the target of the "Install now" buttons from external - grafana.com to an internal plugin details page. This has an advantage that if you have an enterprise license you can install the plugin directly without going to grafana.com
Why do we need this feature?
Easier to install plugins for users with enterprise license.
Who is this feature for?
Enterprise license users