PublicDashboards: Email sharing #63762
Conversation
…banas/emailSharingFeature
…m:grafana/grafana into juanicabanas/sharePublicDashboardRefactor
…banas/emailSharingFeature
juanicabanas
requested review from
axelavargas,
polibb,
ashharrison90,
JoaoSilvaGrafana and
evictorero
and removed request for
a team
| // @ts-ignore | ||
| return requestOptions.manageError ? requestOptions.manageError(error) : { error }; |
There was a problem hiding this comment.
Do not disable the type checker. This will break Grafana in unknown ways. We cannot introduce more type holes and unreliability.
There was a problem hiding this comment.
Instead, I would suggest to revert manageError to accept unknown again, and within your getConfigError/manageError function, you can check if it has a status field after using isFetchError
There was a problem hiding this comment.
I didn't know about that isFetchError function. Looks better now!
|
Making some little modifications |
|
Only issue I ran into was the frontend validation won't let me invite a comma separated list of emails.
|
@owensmallwood for this v1 we don't support a bulk operation |
Feature for sharing a public dashboard by email
What is this feature?
Email sharing option is added for enterprise.
Once enabled, you will be able to share a public dashboard just for the emails you added in the configuration modal.
Why do we need this feature?
It adds a new way of sharing a public dashboard.
Who is this feature for?
Enterprise users
Which issue(s) does this PR fix?:
Fixes #4402, #4401, #4399
email-sharing-demo.mov