Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command Palette: Display dashboard location #63807

Merged
merged 5 commits into from
Mar 1, 2023
Merged

Command Palette: Display dashboard location #63807

merged 5 commits into from
Mar 1, 2023

Conversation

ashharrison90
Copy link
Contributor

@ashharrison90 ashharrison90 commented Feb 27, 2023 •
edited
Loading

What is this feature?

  • shows dashboard location (folder) after the dashboard name
  • changes command palette page result to show hierarchy after name (instead of in front)
  • clamps text/subtitle to 1-line - no more wrapping
    • subtitle should take any available space
    • if there is no available space (e.g. long title), subtitle should take space to fit the subtitle content, up to a max of 20% of width of the row

image

image

image

Why do we need this feature?

  • better UX

Who is this feature for?

  • everyone using command palette

Which issue(s) does this PR fix?:

Fixes #62489

Special notes for your reviewer:

@ashharrison90 ashharrison90 added this to the 9.5.0 milestone Feb 27, 2023
@ashharrison90 ashharrison90 requested a review from a team as a code owner February 27, 2023 16:58
@ashharrison90 ashharrison90 self-assigned this Feb 27, 2023
@ashharrison90 ashharrison90 requested review from joshhunt and yaelleC and removed request for a team February 27, 2023 16:58
eledobleefe
eledobleefe approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@eledobleefe eledobleefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on local and LGTM! 🎉

amy-super
amy-super approved these changes Feb 28, 2023
View reviewed changes
Copy link

@amy-super amy-super left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works really well! It makes results much easier to scan. 🙌

@ashharrison90 ashharrison90 merged commit 27635e6 into main Mar 1, 2023
@ashharrison90 ashharrison90 deleted the ash/62489 branch March 1, 2023 09:46
ryantxu pushed a commit that referenced this pull request Mar 2, 2023
@ashharrison90 @ryantxu
Command Palette: Display dashboard location (#63807)
c82a4cd 
* show folder for dashboard, adjust how ancestors are displayed, clamp to single line

* fix keys

* better responsiveness

* use subtitle consistently

* use span instead of div
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eledobleefe eledobleefe eledobleefe approved these changes

@amy-super amy-super amy-super approved these changes

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

@yaelleC yaelleC Awaiting requested review from yaelleC yaelleC is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees

@ashharrison90 ashharrison90

Labels
add to changelog area/frontend area/navigation no-backport Skip backport of PR
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

CommandPalette: Show folder for dashboard
4 participants
@ashharrison90 @eledobleefe @amy-super @grafanabot