Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pubdash: Email sharing handle dashboard deleted #64247

Merged
merged 28 commits into from Mar 8, 2023
Merged

Pubdash: Email sharing handle dashboard deleted #64247

merged 28 commits into from Mar 8, 2023

Commits on Feb 28, 2023

  1. pubdash service handles dashboard delete WIP

    @owensmallwood
    owensmallwood committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    490bcdc View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. Merge branch 'main' into owensmallwood/pubdash-email-sharing-handle-d… 

    …ashboard-deleted
    @owensmallwood
    owensmallwood committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    cf1e9a5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into owensmallwood/pubdash-email-sharing-handle-d… 

    …ashboard-deleted
    @owensmallwood
    owensmallwood committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    a2b0a7f View commit details
    Browse the repository at this point in the history

  3. updates function name

    @owensmallwood
    owensmallwood committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    ce8c069 View commit details
    Browse the repository at this point in the history

  4. regenerates store mock

    @owensmallwood
    owensmallwood committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    27f2875 View commit details
    Browse the repository at this point in the history

  5. adds service tests

    @owensmallwood
    owensmallwood committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    e9b3fc4 View commit details
    Browse the repository at this point in the history

  6. adds database tests for OSS

    @owensmallwood
    owensmallwood committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    ca50c4c View commit details
    Browse the repository at this point in the history

  7. regenerates service and service wrapper mocks

    @owensmallwood
    owensmallwood committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    22d2dc7 View commit details
    Browse the repository at this point in the history

  8. adds log when call fails to delete pubdash using pubdash service

    @owensmallwood
    owensmallwood committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    b82640b View commit details
    Browse the repository at this point in the history

  9. Merge branch 'main' into owensmallwood/pubdash-email-sharing-handle-d… 

    …ashboard-deleted
    @owensmallwood
    owensmallwood committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    35c635e View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Merge branch 'main' into owensmallwood/pubdash-email-sharing-handle-d… 

    …ashboard-deleted
    @owensmallwood
    owensmallwood committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    bb1461c View commit details
    Browse the repository at this point in the history

  2. renames function to DeleteByDashboard

    @owensmallwood
    owensmallwood committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    4e7bfaa View commit details
    Browse the repository at this point in the history

  3. refactors the Delete() method on the pubdash service to call DeleteBy… 

    …PublicDashboard on the wrapper. Regenerates wrapper mock and fixes failing tests.
    @owensmallwood
    owensmallwood committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    92bf3ef View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into owensmallwood/pubdash-email-sharing-handle-d… 

    …ashboard-deleted
    @owensmallwood
    owensmallwood committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    b09b8d6 View commit details
    Browse the repository at this point in the history

  5. fixes failing tests

    @owensmallwood
    owensmallwood committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    940f63d View commit details
    Browse the repository at this point in the history

  6. regenerates mock

    @owensmallwood
    owensmallwood committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    b80ebfc View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. renames a few functions, fixes query, removes pubdash deletes from da… 

    …shboard database layer, updates tests, regenerates mock
    @owensmallwood
    owensmallwood committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    e096505 View commit details
    Browse the repository at this point in the history

  2. removes tests from dashboard service for making sure pubdash gets del… 

    …eted during dashboard deletion
    @owensmallwood
    owensmallwood committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    a3763bf View commit details
    Browse the repository at this point in the history

  3. fixes issue for the case where pubdash is not found. Adds test

    @owensmallwood
    owensmallwood committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    1cd592e View commit details
    Browse the repository at this point in the history

  4. checks error in test setup

    @owensmallwood
    owensmallwood committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    726feb5 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into owensmallwood/pubdash-email-sharing-handle-d… 

    …ashboard-deleted
    @owensmallwood
    owensmallwood committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    065f9da View commit details
    Browse the repository at this point in the history

  6. refactors delete method to only accept pubdash uid

    @owensmallwood
    owensmallwood committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    106208e View commit details
    Browse the repository at this point in the history

  7. returns nil instead of empty slice

    @owensmallwood
    owensmallwood committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    17e2ed7 View commit details
    Browse the repository at this point in the history

  8. use error plane error in service

    @owensmallwood
    owensmallwood committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    ff66e83 View commit details
    Browse the repository at this point in the history

  9. deleting a pubdash returns nil when nothing is deleted instead of error

    @owensmallwood
    owensmallwood committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    3f1029c View commit details
    Browse the repository at this point in the history

  10. updates query to get all pubdashes for dashboard folder

    @owensmallwood
    owensmallwood committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    6d6b9b7 View commit details
    Browse the repository at this point in the history

  11. formats imports

    @owensmallwood
    owensmallwood committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    5d7ae1e View commit details
    Browse the repository at this point in the history

  12. updates query and test

    @owensmallwood
    owensmallwood committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    795cffc View commit details
    Browse the repository at this point in the history