Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TablePanel: fix footer bug; no footer calculated values after "hidden" column override #64269

Merged
merged 21 commits into from
Mar 8, 2023

Conversation

baldm0mma
Copy link
Contributor

@baldm0mma baldm0mma commented Mar 6, 2023

What is this feature?

Bug fix where footer values aren't rendering properly on hide in table column override. Specifically the footer calculation that is the index directly after an override "hidden" column. See #58896 issue.

Why do we need this feature?

Bugs are bad, m'cay?

Who is this feature for?

Everyone.

Which issue(s) does this PR fix?:

Fixes #58896

Special notes for your reviewer:
N/A

Before:
Screenshot 2023-03-06 at 2 54 57 PM (2)

After:
Screenshot 2023-03-06 at 2 59 20 PM (2)

@baldm0mma baldm0mma changed the title Baldm0mma/bug/table footer fix TablePanel: fix footer bug; no footer value on no-show override Mar 6, 2023
@baldm0mma baldm0mma self-assigned this Mar 6, 2023
@baldm0mma baldm0mma added this to the 9.5.0 milestone Mar 6, 2023
@baldm0mma baldm0mma added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Mar 6, 2023
@baldm0mma baldm0mma marked this pull request as ready for review March 7, 2023 00:13
@baldm0mma baldm0mma requested review from a team and codeincarnate and removed request for a team March 7, 2023 00:13
@baldm0mma baldm0mma changed the title TablePanel: fix footer bug; no footer value on no-show override TablePanel: fix footer bug; no footer calculated values after "hidden" column override Mar 7, 2023
Copy link
Collaborator

@codeincarnate codeincarnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments are great! And tested out the fix and appears to work just fine. I think adding the TSDoc comment to the added function would be awesome but otherwise looks good 😄

Copy link
Collaborator

@codeincarnate codeincarnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

@baldm0mma baldm0mma merged commit 09341a0 into main Mar 8, 2023
@baldm0mma baldm0mma deleted the baldm0mma/bug/tableFooterFix branch March 8, 2023 13:57
@baldm0mma baldm0mma added add to changelog and removed no-changelog Skip including change in changelog/release notes labels Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TablePanel: Footer works incorrectly with 'Hide in table'
3 participants