-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TablePanel: fix footer bug; no footer calculated values after "hidden" column override #64269
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments are great! And tested out the fix and appears to work just fine. I think adding the TSDoc comment to the added function would be awesome but otherwise looks good 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🚀
What is this feature?
Bug fix where footer values aren't rendering properly on hide in table column override. Specifically the footer calculation that is the index directly after an override "hidden" column. See #58896 issue.
Why do we need this feature?
Bugs are bad, m'cay?
Who is this feature for?
Everyone.
Which issue(s) does this PR fix?:
Fixes #58896
Special notes for your reviewer:
N/A
Before:
![Screenshot 2023-03-06 at 2 54 57 PM (2)](https://user-images.githubusercontent.com/46619047/223244106-3b3fd276-6fcd-4010-bee1-775050053a37.png)
After:
![Screenshot 2023-03-06 at 2 59 20 PM (2)](https://user-images.githubusercontent.com/46619047/223244559-0dfa2412-de1e-484f-8725-f2b794cd33ab.png)