Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stat: Add ability to remove default single-color background gradient #64353

Merged
merged 19 commits into from
Mar 14, 2023
Merged

Stat: Add ability to remove default single-color background gradient #64353

merged 19 commits into from
Mar 14, 2023

Conversation

baldm0mma
Copy link
Contributor

@baldm0mma baldm0mma commented Mar 7, 2023 •
edited
Loading

What is this feature?

This add the ability for the user to remove the color gradient and solid background colors in the stat panel. A boolean toggle renders when the colorMode is switched to "Background' - seeing as background is the the only value the gradient background applies to - and the user can switch from gradient to non-gradient.

Why do we need this feature?

In almost all BI use cases, it is core to the usability of a stat panel to follow - to a tee - the branding color. The default solid color gradient makes this impossible, and is a deal-breaker for many organizations.

Who is this feature for?

Everyone.

Which issue(s) does this PR fix?:

N/A

Special notes for your reviewer:

Screen.Recording.2023-03-09.at.6.54.51.AM.mov

@baldm0mma baldm0mma changed the title baldm0mma/feature/solidOption/ update cue and ts types Stat Panel: feature - add ability to remove default single-color background gradient Mar 7, 2023
baldm0mma and others added 15 commits March 7, 2023 14:33
@baldm0mma
baldm0mma/feature/solidOption/ update data structures
88244d3
@baldm0mma
baldm0mma/feature/solidOption/ vizrepeater investigation
0d7130a
@baldm0mma
baldm0mma/feature/solidOption/ add buildGradientBackground
b722bd3
@baldm0mma
baldm0mma/feature/solidOption/ remove conlogs from fieldDisplay.ts
d01338a
@baldm0mma
baldm0mma/feature/solidOption/ rem destruct in fielddisplay.ts
ef1f886
@baldm0mma
baldm0mma/feature/solidOption/ rem conlogs from bivaluelayout.tsx
a7f0216
@baldm0mma
baldm0mma/feature/solidOption/ rem conlogs in visrepeater
099b763
@baldm0mma
baldm0mma/feature/solidOption/ rem conlogs from statpanel.tsx
e7d0a74
@baldm0mma
baldm0mma/feature/solidOption/ add annotations in BigValue.tsx
89e097b
@baldm0mma
baldm0mma/feature/solidOption/ update cue
6d08881
@baldm0mma
baldm0mma/feature/solidOption/ remove unused anno
0282bbc
@baldm0mma
baldm0mma/feature/solidOption/ update with toggle conditinal
0d1597d
@baldm0mma
Update module.tsx
c7d6057 
update anno
@baldm0mma
baldm0mma/feature/solidOption/ update annos
16cd1af
@baldm0mma
baldm0mma/feature/solidOption/ undo change
bef3d82
@baldm0mma baldm0mma self-assigned this Mar 9, 2023
@baldm0mma baldm0mma added this to the 9.5.0 milestone Mar 9, 2023
@baldm0mma baldm0mma marked this pull request as ready for review March 9, 2023 13:58
@baldm0mma baldm0mma requested a review from a team March 9, 2023 13:58
@baldm0mma baldm0mma requested review from a team as code owners March 9, 2023 13:58
@baldm0mma baldm0mma requested review from a team and Eve832 as code owners March 9, 2023 13:58
@baldm0mma baldm0mma requested review from codeincarnate, oscarkilhed, ashharrison90, yaelleC and andresmgot and removed request for a team March 9, 2023 13:58
@baldm0mma baldm0mma changed the title Stat Panel: feature - add ability to remove default single-color background gradient StatPanel: add ability to remove default single-color background gradient Mar 9, 2023
@baldm0mma baldm0mma changed the title StatPanel: add ability to remove default single-color background gradient StatPanel: Add ability to remove default single-color background gradient Mar 9, 2023
@baldm0mma baldm0mma changed the title StatPanel: Add ability to remove default single-color background gradient Stat: Add ability to remove default single-color background gradient Mar 9, 2023
codeincarnate
codeincarnate reviewed Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@codeincarnate codeincarnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it out and works fine. See my comments (which are kind of nitpicky 😂) but with those changes I think it would be fine 😄

public/app/plugins/panel/stat/module.tsx Show resolved Hide resolved
packages/grafana-ui/src/components/BigValue/BigValue.tsx Outdated Show resolved Hide resolved
@baldm0mma baldm0mma merged commit de90156 into main Mar 14, 2023
@baldm0mma baldm0mma deleted the baldm0mma/feature/solidOption branch March 14, 2023 14:59
torkelo added a commit that referenced this pull request Mar 19, 2023
@torkelo
Revert "Stat: Add ability to remove default single-color background g…
d81f32a 
…radient (#64353)"

This reverts commit de90156.
@torkelo torkelo mentioned this pull request Mar 19, 2023
Merged
torkelo added a commit that referenced this pull request Mar 20, 2023
@torkelo
Revert "Stat: Add ability to remove default single-color background g…
18385bf 
…radient" (#65002)

Revert "Stat: Add ability to remove default single-color background gradient (#64353)"

This reverts commit de90156.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantxu ryantxu ryantxu approved these changes

@Eve832 Eve832 Awaiting requested review from Eve832 Eve832 is a code owner

@oscarkilhed oscarkilhed Awaiting requested review from oscarkilhed

@ashharrison90 ashharrison90 Awaiting requested review from ashharrison90 ashharrison90 is a code owner automatically assigned from grafana/grafana-frontend-platform

@yaelleC yaelleC Awaiting requested review from yaelleC yaelleC is a code owner automatically assigned from grafana/grafana-frontend-platform

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot is a code owner automatically assigned from grafana/plugins-platform-frontend

@codeincarnate codeincarnate Awaiting requested review from codeincarnate

Assignees

@baldm0mma baldm0mma

Labels
add to changelog area/frontend area/panel/stat no-backport Skip backport of PR type/docs
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@baldm0mma @codeincarnate @ryantxu @grafanabot