-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerting: Support filtering rules by multiple datasources #64355
Conversation
ea86713
to
9ef356e
Compare
public/app/features/alerting/unified/components/rules/MultipleDataSourcePicker.tsx
Outdated
Show resolved
Hide resolved
I think one feature I'd love to see is dividing the list of options in the select component in 2 distinct groups:
As a user I'd love to be able to quickly select from a set of data sources (Prometheus and Loki) that have
|
9842a58
to
2a104fe
Compare
@gillesdemey I've implemented a grouped version of it, let me know if this looks better, thanks! 🙏 |
That looks amazing! 🤩 Tagging @brendamuir here to refine the wording / terminology here a bit. |
Hey-what does "data sources that manage alert rules mean" and how are they different to "other data sources"? |
Data sources that manage alert rules. |
I'm sure @gillesdemey can explain this better, but from what I can tell the difference resides on whether the "Manage alerts via the Alerting UI" setting in the admin section of the datasource is turned on or off So basically the datasources that don't have the option turned on are listed under "Other datasources" and the difference is they don't manage alerts from within Grafana. I believe only Prometheus and Loki will fall under the first category as those are the ones that we support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code and implementation are ready to 🚀
@brendamuir I can wait for your input before merging, let me know if you need extra clarification, thank you!! |
I've updated the texts according to our conversation in Slack. Please let me know if it looks better now, thank you! |
* Support having a datasources array in the rules filter * Fix tests * Display a MultiplePicker for filtering datasources * Fix tests * Refactor as MultipleDataSourcePicker as FC * Make select box wider * Remove FC from component definition * Display ds options in groups based on whether they manage/don't manage rules * Change dropdown texts and add help info
What is this feature?
Adds support to filter rules by multiple datasources
Why do we need this feature?
Right now we can only filter by one datasource and this would be useful for users with several configured ones.
Who is this feature for?
All users.
Which issue(s) does this PR fix?:
Fixes #62969
Special notes for your reviewer: