Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions: Expose an enum for available placements #64586

Merged
merged 2 commits into from
Mar 10, 2023

Conversation

leventebalogh
Copy link
Contributor

What changed?

Exposed an enum called PluginExtensionPlacements with the available extensions placements inside Grafana. Until now we were using an enum called GrafanaExtensions, however that was not exposed publicly, so plugins couldn't depend on it.

@leventebalogh leventebalogh added this to the 9.5.0 milestone Mar 10, 2023
@leventebalogh leventebalogh self-assigned this Mar 10, 2023
@leventebalogh leventebalogh requested review from a team as code owners March 10, 2023 08:07
@leventebalogh leventebalogh requested review from mckn, dprokop, ivanortegaalba, joshhunt, JoaoSilvaGrafana and jackw and removed request for a team March 10, 2023 08:07
Copy link
Contributor

@jackw jackw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@leventebalogh leventebalogh merged commit 7915296 into main Mar 10, 2023
@leventebalogh leventebalogh deleted the leventebalogh/extension-placements branch March 10, 2023 12:55
eleijonmarck pushed a commit that referenced this pull request Mar 13, 2023
* feat: expose an enum type for extension placements

* fix: export the enum properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants