Prometheus/Loki: Run query explicitly instead of onblur in panel edit #64815
Conversation
… highlight Run qqueries when query changed
torkelo
changed the title
|
maybe useful to add an Enter or Shift + Enter or Ctrl + Enter shortcut to run queries, too? |
There was a problem hiding this comment.
Loki change LGTM.
(Prom also, but I'll defer to the metrics squad).
maybe useful to add an Enter or Shift + Enter or Ctrl + Enter shortcut to run queries, too?
@leeoniya yea, Shift+Enter is already working to run queries.
|
Backend code coverage report for PR #64815 |
|
Frontend code coverage report for PR #64815
|
| @@ -76,7 +76,7 @@ export class LokiQueryField extends React.PureComponent<LokiQueryFieldProps, Lok | |||
| > | |||
| <div className="gf-form gf-form--grow flex-shrink-1 min-width-15"> | |||
| <MonacoQueryFieldWrapper | |||
| runQueryOnBlur={app !== CoreApp.Explore} | |||
| runQueryOnBlur={false} | |||
There was a problem hiding this comment.
I think we can safely remove this prop and all related code, since it was only used for the on-blur run in dashboards.
There was a problem hiding this comment.
Done removed this prop for both the prometheus and loki variant
|
@leeoniya I think they already exist |
|
Personally, I like the onBlur behavior maybe because I am used to it. And I see we add this in the changelog so users like me will be aware of that change 🤞. Highlighting the Run queries button is also a good touch. |
@itsmylife only from internal users so far, and some comments here #51979 |
Edit-panel---prometheus-query-max---Dashboards---Grafana.webm