Table: Fixes table panel gauge alignment #64994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
requested review from
oscarkilhed,
baldm0mma,
ashharrison90 and
andresmgot
and removed request for
a team
torkelo
requested review from
codeincarnate and
mdvictor
and removed request for
joshhunt,
baldm0mma,
ashharrison90 and
andresmgot
torkelo
added
add to changelog
no-backport
torkelo
changed the title
|
You have successfully added a new CodeQL configuration |
baldm0mma
reviewed
Mar 20, 2023
zoltanbedi
reviewed
Mar 22, 2023
| // look at the next 100 rows | ||
| alignmentFactor = { ...displayValue }; | ||
|
|
||
| for (let i = rowIndex + 1; i < field.values.length; i++) { |
There was a problem hiding this comment.
While the comment says to look at the next 100 rows it doesn't. It looks for the whole length. I tried this out with a data that is 200.000 long and I didn't notice performance degradation so maybe we can leave it as it is?
There was a problem hiding this comment.
@zoltanbedi good catch, will fix it.
zoltanbedi
approved these changes
Mar 22, 2023
| } | ||
| return alignmentFactor; | ||
| } else { | ||
| // look at the next 100 rows |
There was a problem hiding this comment.
Suggested change
| // look at the next 100 rows | |
| // look at the next 1000 rows |
gotjosh
pushed a commit
that referenced
this pull request
Mar 27, 2023
* Table: Fixes tables guage alignment issues * Removed console.log * Fixing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #40925
This is a pretty tricky problem to solve without impacting table panel performance, but I think I found a pretty good compromise that should not impact performance much. it does not solve the problem completely, it can still happen but should be much more uncommon to occur.
Before:
After:
