-
Notifications
You must be signed in to change notification settings - Fork 11.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TablePanel: POC of custom cell rendering from plugins #64999
Conversation
* Dynamically build data links * Add field override tests
export interface TableCustomCellOptions { | ||
cellComponent: string; | ||
type: TableCellDisplayMode.Custom; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how to type a react component in cue 🤣
You have successfully added a new CodeQL configuration |
export interface CustomCellRendererProps { | ||
field: Field; | ||
value: any; | ||
// what else to pass in order to make it more agnostic to table internals? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
field & value maybe be enough. Can use a transformer to pass what's needed as a value
nice, this will be very useful :) |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
This is a POC of how we can allow plugins to do custom cell rendering.
Scenarios
Implementation problems