-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sticky variables submenu #65003
sticky variables submenu #65003
Conversation
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this on the latest main and could not get it to work.
Try merging with main, main has new nav enabled as well so could be that.
Not sure we want to add this until we do some bigger changes to DashboardsPage, we are thinking of adding an edit mode and moving down time range into the canvas (on the right side), and that move would benefit a sticky submenu. So interested in how that could be implemented. But the timeline for those things are probably after summer
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Hey @Smeany 👋🏾 , thank you so much for your contribution! We truly appreciate your effort. However, I'm temporarily closing this PR because, as Torkel mentioned, a more significant refactor is needed on the dashboard page. We have long-term plans to address this issue in the future. Thank you 🙏🏾 |
What is this feature?
Makes the variables toolbar on the dashboard page sticky. In addition to that it's visibility is dependant on mousescrolls. When you are at the top of the page or scroll down the toolbar slides into the view and if you scroll up it disappears, giving you maxium viewspace of the dashboard.
Why do we need this feature?
As requested by Issue #11166