Elasticsearch: Fix processing of response with multiple group by for alerting #65165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend code coverage report for PR #65165
|
|
Frontend code coverage report for PR #65165 |
gabor
approved these changes
Mar 22, 2023
gotjosh
pushed a commit
that referenced
this pull request
Mar 27, 2023
…alerting (#65165) * Elasticsearch: Fix processing of response with multiple group by on backend * Remove unused param from createFields * Switch comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes processing of response with multiple group by on backend. On backend, we were missing using fields from frames if there already were any, and add fields from
propKeysif there weren't any. This is correctly done on frontend implementation where we check if we have anycolumnsand if yes, we use them instead of addingpropKeys.Fixes: #64727
Part of #54011
How to test:
elasticsearchBackendMigration=truerunmake devenv sources=elastic
4. There should be a correct response in table