Alerting: Improve query types usage to prevent ts-errors

[VikaCep]

What is this feature?

Removes the usage of ts-ignore when accessing the expr property for recording rules queries after #63260. Instead of that, proper types are assigned where needed.

Why do we need this feature?

To improve code quality.

[github-advanced-security]

You have successfully added a new CodeQL configuration .github/workflows/pr-codeql-analysis-javascript.yml:analyze. As part of the setup process, we have scanned this repository and found 29 existing alerts. Please check the repository Security tab to see all alerts.

[soniaAguilarPeiron]

LGTM! Maybe we could do it differently so we avoid adding a parameter to onChangeQuery?

[gillesdemey]

This makes more sense to me 👍

On a side note I think we should probably have stricter typing than the generic AlertQuery (and it looks like mapToQuery doesn't event return a specific type, but just DataQuery & { expr: string } :(

[VikaCep]

I changed the approach by using a new helper function isPromOrLokiQuery which basically checks that the query's model contains the expr property (which is the only one that's not optional in PromQuery and LokiQuery). Using this method I no longer need mapToQuery or passing an extra parameter to onChangeQuery. Let me know if this looks better, thanks! 🙏