-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HeatMap: Sort y buckets when all bucket names are numeric #65322
Conversation
You have successfully added a new CodeQL configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution appears to resolve this issue with correct sorting - though I am not confident on the direction in which we are displaying the sorted list (seems to make more sense to show low -> high along the y axis)
Testing this issue's dashboard locally it appears that this solution is not working. Are there additional query settings / transforms that need to be set in order for this solution to work in more cases?
that debug panel has an explicit reverse configured:
you're right. that dashboard has a response with multiple nameless frames that have time+value fields. i added more magic to make it work :( |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-65322-to-v9.4.x origin/v9.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 6f4232bee383a7782ebbdcd31624f11a2d2bdfab
# Push it to GitHub
git push --set-upstream origin backport-65322-to-v9.4.x
git switch main
# Remove the local backport branch
git branch -D backport-65322-to-v9.4.x Then, create a pull request where the |
(cherry picked from commit 6f4232b)
I'm still facing this issue, with the current main branch on my local instance Just to be super sure, also checked whether I really have the commit in my history Here's the paste from "get help" |
we expect either maybe take a look at the the influx queries in #60545 to see how to make sure the columns/fields contain the bucket names. if you open a new issue with your previous comment/snapshot, we can discuss whether it makes sense for us to also probe |
Fixes #60545
Fixes #65314
i don't think this is the proper solution, but it is an easy one that works.
i think we need to move away from handling every format at every level:
ideally panels have a single, pre-defined shape that they accept, and we auto-suggest and explicitly add the necessary transformers that get data into this shape. related: #64092, cc @grafana/data-plane-wg.