Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation: Enable new navigation by default #65335

Merged
merged 5 commits into from
Mar 30, 2023

Conversation

ashharrison90
Copy link
Contributor

@ashharrison90 ashharrison90 commented Mar 27, 2023

What is this feature?

  • enables the new navigation layout in grafana by default

Why do we need this feature?

  • better navigation experience!

Who is this feature for?

  • everyone!

Which issue(s) does this PR fix?:

Fixes #50791

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.
  • There are no known compatibility issues with older supported versions of Grafana, or plugins.
  • It passes the Hosted Grafana feature readiness review for observability, scalability, performance, and security.

@ashharrison90 ashharrison90 added this to the 9.5.0 milestone Mar 27, 2023
@ashharrison90 ashharrison90 requested a review from a team March 27, 2023 09:34
@ashharrison90 ashharrison90 self-assigned this Mar 27, 2023
@ashharrison90 ashharrison90 requested review from yaelleC and JoaoSilvaGrafana and removed request for a team March 27, 2023 09:34
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-codeql-analysis-javascript.yml:analyze. As part of the setup process, we have scanned this repository and found 29 existing alerts. Please check the repository Security tab to see all alerts.

@ashharrison90 ashharrison90 marked this pull request as ready for review March 27, 2023 15:58
@ashharrison90 ashharrison90 requested review from a team and chri2547 as code owners March 27, 2023 15:58
@ashharrison90 ashharrison90 requested review from mildwonkey, suntala and yangkb09 and removed request for a team March 27, 2023 15:58
@@ -27,6 +27,7 @@ Some stable features are enabled by default. You can disable a stable feature by
| `cloudWatchDynamicLabels` | Use dynamic labels instead of alias patterns in CloudWatch datasource | Yes |
| `dataConnectionsConsole` | Enables a new top-level page called Connections. This page is an experiment that provides a better experience when you install and configure data sources and other plugins. | Yes |
| `internationalization` | Enables internationalization | Yes |
| `topnav` | Displays new top nav and page layouts | Yes |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `topnav` | Displays new top nav and page layouts | Yes |
| `topnav` | Enables new top navigation and page layouts | Yes |

Copy link
Collaborator

@chri2547 chri2547 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small docs suggestion. Thanks for the contribution!

@ashharrison90 ashharrison90 requested a review from a team as a code owner March 28, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Navigation: Phase 2 🚀
4 participants