Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL Datasources: Add back help content #65383

Merged
merged 1 commit into from
Mar 30, 2023
Merged

SQL Datasources: Add back help content #65383

merged 1 commit into from
Mar 30, 2023

Conversation

zoltanbedi
Copy link
Member

@zoltanbedi zoltanbedi commented Mar 27, 2023 •
edited
Loading

This PR adds back the help for SQL datasources. It is now not in the query editor but instead uses the toolbar as the other datasources.
Screenshot 2023-03-27 at 18 01 08
Screenshot 2023-03-27 at 18 00 44

Which issue(s) does this PR fix?:

Fixes #65382

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.
  • There are no known compatibility issues with older supported versions of Grafana, or plugins.
  • It passes the Hosted Grafana feature readiness review for observability, scalability, performance, and security.

@zoltanbedi zoltanbedi added this to the 9.5.0 milestone Mar 27, 2023
@zoltanbedi zoltanbedi requested a review from a team March 27, 2023 15:44
@zoltanbedi zoltanbedi self-assigned this Mar 27, 2023
@zoltanbedi zoltanbedi requested review from codeincarnate and baldm0mma and removed request for a team March 27, 2023 15:44
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-codeql-analysis-javascript.yml:analyze. As part of the setup process, we have scanned this repository and found 27 existing alerts. Please check the repository Security tab to see all alerts.

codeincarnate
codeincarnate approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@codeincarnate codeincarnate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out and all the help appears to be working good! 😎

baldm0mma
baldm0mma reviewed Mar 29, 2023
View reviewed changes
Copy link
Contributor

@baldm0mma baldm0mma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks great!

@zoltanbedi zoltanbedi merged commit a0e0af2 into main Mar 30, 2023
@zoltanbedi zoltanbedi deleted the zoltan/sql-help branch March 30, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baldm0mma baldm0mma baldm0mma left review comments

@codeincarnate codeincarnate codeincarnate approved these changes

Assignees

@zoltanbedi zoltanbedi

Labels
add to changelog area/frontend datasource/MSSQL Microsoft SQL Server Data Source datasource/MySQL datasource/Postgres no-backport Skip backport of PR
Projects
None yet
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

SQL Datasources: Add back help
4 participants
@zoltanbedi @codeincarnate @baldm0mma @grafanabot