Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerting: Add "backend" label to state history writes metrics #65395

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Alerting: Add "backend" label to state history writes metrics #65395

merged 2 commits into from
Mar 28, 2023

Conversation

alexweav
Copy link
Contributor

What is this feature?

Right now you can't calculate write rates for specific backends, because all writes are lumped into the same metric. This makes the metric not as useful.

Why do we need this feature?

Allows more granular observability of writes around specific implementations.

Who is this feature for?

Operators of Grafana.

Which issue(s) does this PR fix?:

n/a

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.
  • There are no known compatibility issues with older supported versions of Grafana, or plugins.
  • It passes the Hosted Grafana feature readiness review for observability, scalability, performance, and security.

@alexweav alexweav added type/bug area/alerting Grafana Alerting area/backend add to changelog backport v9.4.x Mark PR for automatic backport to v9.4.x labels Mar 27, 2023
@alexweav alexweav added this to the 9.4.x milestone Mar 27, 2023
@alexweav alexweav requested a review from a team March 27, 2023 18:10
yuri-tceretian
yuri-tceretian approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@yuri-tceretian yuri-tceretian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gotjosh
gotjosh approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@gotjosh gotjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexweav alexweav merged commit dd04757 into main Mar 28, 2023
@alexweav alexweav deleted the alexweav/writes-by-backend branch March 28, 2023 13:49
@grafanabot grafanabot mentioned this pull request Mar 28, 2023
Merged
grafanabot pushed a commit that referenced this pull request Mar 28, 2023
@alexweav @grafanabot
Alerting: Add "backend" label to state history writes metrics (#65395)
e92da79 
* Add backend label to state history writes metrics

* Update test expectations

(cherry picked from commit dd04757)
alexweav added a commit that referenced this pull request Mar 28, 2023
@grafanabot @alexweav
[v9.4.x] Alerting: Add "backend" label to state history writes metrics (
1b8d220 
#65453)

Alerting: Add "backend" label to state history writes metrics (#65395)

* Add backend label to state history writes metrics

* Update test expectations

(cherry picked from commit dd04757)

Co-authored-by: Alexander Weaver <weaver.alex.d@gmail.com>
@zerok zerok modified the milestones: 9.4.x, 9.4.8, 9.5.0 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotjosh gotjosh gotjosh approved these changes

@yuri-tceretian yuri-tceretian yuri-tceretian approved these changes

Assignees
No one assigned
Labels
add to changelog area/alerting Grafana Alerting area/backend backport v9.4.x Mark PR for automatic backport to v9.4.x kata:state-history type/bug
Projects
Alerting
Archived in project
Milestone
9.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexweav @gotjosh @yuri-tceretian @zerok