Alerting: Add alert instance labels to Loki log lines in addition to stream labels #65403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Right now, we merge instance labels with a few pre-defined stream labels like
ruleUID
andfrom="state-history"
.A consequence of this, is that it becomes impossible to calculate the exact set of labels attached to the corresponding alert instance. For example, the user might have created labels with keys called
from
, which collides with the stream labels. Then, it's impossible to disambiguate stream labels from what the underlying instance labels were, so it's hard to track the entry back to the original instance.This PR puts the instance labels, on their own, into the log lines too, under a block called
labels
. You can query it likeWhy do we need this feature?
The data that Loki indexes should be separate from the semantics of what actually gets recorded. Helps with querying. This also allows the UI to link an ASH entry back to an instance, which could be useful in the future.
Who is this feature for?
More clear queries of state history rows.
Which issue(s) does this PR fix?:
n/a
Special notes for your reviewer:
Please check that: