Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimePicker: Can now select time correctly #65428

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Conversation

eledobleefe
Copy link
Contributor

What is this feature?
It allows the user to select time in the DateTimePicker.

Why do we need this feature?
To be able to select a value on TimeOfDayPicker and keep it.

Who is this feature for?
Everyone

Which issue(s) does this PR fix?:
Fixes #65262

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.
  • There are no known compatibility issues with older supported versions of Grafana, or plugins.
  • It passes the Hosted Grafana feature readiness review for observability, scalability, performance, and security.

@eledobleefe eledobleefe added add to changelog area/grafana/ui Issues that belong to components in the @grafana/ui library mob session Something solved during a mob session backport v9.4.x Mark PR for automatic backport to v9.4.x labels Mar 28, 2023
@eledobleefe eledobleefe added this to the 9.5.0 milestone Mar 28, 2023
@eledobleefe eledobleefe requested a review from a team as a code owner March 28, 2023 10:27
@eledobleefe eledobleefe requested review from tskarhed and ashharrison90 and removed request for a team March 28, 2023 10:27
@grafanabot
Copy link
Contributor

Hello @eledobleefe!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@eledobleefe eledobleefe modified the milestones: 9.5.0, 9.4.x Mar 28, 2023
@eledobleefe eledobleefe changed the title Grafana UI: Not possible to select time in DateTimePicker DateTimePicker: Can now select time correctly Mar 28, 2023
Copy link
Contributor

@ashharrison90 ashharrison90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good mob 🔱

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-codeql-analysis-javascript.yml:analyze. As part of the setup process, we have scanned this repository and found 27 existing alerts. Please check the repository Security tab to see all alerts.

@eledobleefe eledobleefe merged commit 48f5825 into main Mar 28, 2023
@eledobleefe eledobleefe deleted the ue-date-time-picker branch March 28, 2023 10:45
grafanabot pushed a commit that referenced this pull request Mar 28, 2023
@zerok zerok modified the milestones: 9.4.x, 9.4.8 Apr 12, 2023
@zerok zerok added this to the 9.5.0 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend area/grafana/ui Issues that belong to components in the @grafana/ui library backport v9.4.x Mark PR for automatic backport to v9.4.x mob session Something solved during a mob session type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GrafanaUI: Not possible to select time in DateTimePicker
5 participants