ErrorView: Better detection of no-data responses #65477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeoniya
added
type/bug
add to changelog
area/panel/timeseries
leeoniya
requested review from
joshhunt and
ashharrison90
and removed request for
a team
|
You have successfully added a new CodeQL configuration |
nmarrs
approved these changes
Mar 28, 2023
| @@ -67,7 +67,7 @@ function getMessageFor( | |||
| } | |||
|
|
|||
| // In some cases there is a data frame but with no fields | |||
There was a problem hiding this comment.
We may also want to update / remove this comment as new logic doesn't match 🤔
torkelo
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/grafana/support-escalations/issues/5218
@torkelo was there a specific reason for only checking when
data.series.length === 1?