AzureMonitor: Fix Log Analytics portal links #65482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Build portal URL in backend - Correctly set multiple resource value - Move AddConfigLinks util function - Add necessary types - Remove unused functions
aangelisc
added
datasource/Azure
aangelisc
requested review from
asimpson and
bossinc
and removed request for
a team
aangelisc
changed the title
|
You have successfully added a new CodeQL configuration |
|
Backend code coverage report for PR #65482
|
|
Frontend code coverage report for PR #65482
|
asimpson
approved these changes
Mar 29, 2023
aangelisc
added
backport v9.4.x
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-65482-to-v9.4.x origin/v9.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x e27cb67776de4872ac00fa9fcb441a9d611b0c22
# Push it to GitHub
git push --set-upstream origin backport-65482-to-v9.4.x
git switch main
# Remove the local backport branch
git branch -D backport-65482-to-v9.4.xThen, create a pull request where the |
grafanabot
added
the
backport-failed
aangelisc
added a commit
that referenced
this pull request
May 16, 2023
* Fix and update Log Analytics portal links - Build portal URL in backend - Correctly set multiple resource value - Move AddConfigLinks util function - Add necessary types - Remove unused functions * Fix lint issue * Remove unused cache variable (cherry picked from commit e27cb67) # Conflicts: # .betterer.results
This was referenced May 16, 2023
aangelisc
added a commit
that referenced
this pull request
May 16, 2023
AzureMonitor: Fix Log Analytics portal links (#65482) * Fix and update Log Analytics portal links - Build portal URL in backend - Correctly set multiple resource value - Move AddConfigLinks util function - Add necessary types - Remove unused functions * Fix lint issue * Remove unused cache variable (cherry picked from commit e27cb67) # Conflicts: # .betterer.results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Log Analytics deep links no longer worked since the multiple resource picker feature was enabled. This PR fixes that issue by appropriately setting the resources field.
Additionally, I've moved the logic of adding the links to be in the backend to align with the other pseudo-datasources. This has allowed for a fair bit of code to be removed from the frontend, simplifying the Log Analytics datasource. This will also simplify some of the Traces work.
Further work will need to be done to appropriately test the backend response building as this doesn't exist yet. See #65481