Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards: Fix Mobile support dashboard issues on new iOS 16.3 #65542

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

axelavargas
Copy link
Member

What is this feature?

In some cases, using -webkit-overflow-scrolling: touch can lead to rendering issues, such as elements not being visible. We received reports of variables and some panels not being visible on iOS devices with version 16.3 or higher. Upon investigation, we found that our CustomScrollbar component uses a library that adds this property, causing these issues. In this PR, I override that style to auto to fix the visibility problems.

I tested the solution using BrowserStack (on a real device), and it resolved the issue.

screenRecording-29-2-2023-16-29.mp4

Which issue(s) does this PR fix?:

Fixes #61915

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.
  • There are no known compatibility issues with older supported versions of Grafana, or plugins.
  • It passes the Hosted Grafana feature readiness review for observability, scalability, performance, and security.

@axelavargas axelavargas added this to the 9.5.0 milestone Mar 29, 2023
@axelavargas axelavargas self-assigned this Mar 29, 2023
@axelavargas axelavargas requested a review from a team as a code owner March 29, 2023 14:49
@axelavargas axelavargas requested review from tskarhed, ashharrison90, a team, polibb and evictorero and removed request for a team March 29, 2023 14:49
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-codeql-analysis-javascript.yml:analyze. As part of the setup process, we have scanned this repository and found 27 existing alerts. Please check the repository Security tab to see all alerts.

Copy link
Contributor

@juanicabanas juanicabanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it! 🚀

@axelavargas axelavargas modified the milestone: 9.5.0 Mar 29, 2023
Copy link
Contributor

@polibb polibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@axelavargas axelavargas merged commit 3ad4dc1 into main Mar 30, 2023
@axelavargas axelavargas deleted the axelav/ios-bug branch March 30, 2023 07:47
@shezhangzhang
Copy link
Contributor

Can we merge this awesome PR to 9.2.x? Because 9.3.x+ changed a lot (navigation), we stay at 9.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Dashboards: Mobile support: Dashboard issues on new iOS 16.3
5 participants