New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transformations: Improve UX and fix refId issues #65982
Conversation
You have successfully added a new CodeQL configuration |
@torkelo I pushed a change to this that moves the core logic to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@torkelo ... approving, but you should check my work (mostly moving yours!)
Also, IIUC, this should not be backported -- it does not seem urgent enough to require the extra attention needed for that.
@ryantxu added a react testing lib unit test for the RefIDPicker component, feels like that logic should have tests :) |
But I am confused by this Select. It shows frames, but the value is the refId so it filters by refId but shows frames? Missing a group by / unique check?
A single query that returns 50 frames will show 50 frames in that select all with the same refId
Bug