Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transformations: Improve UX and fix refId issues #65982

Merged
merged 6 commits into from Apr 7, 2023
Merged

Conversation

torkelo
Copy link
Member

@torkelo torkelo commented Apr 5, 2023

  • Fixes strange h5 field label (replaced by normal Field)
  • Tries to fix the "Query undefined" issue for data sources that don't set refId

But I am confused by this Select. It shows frames, but the value is the refId so it filters by refId but shows frames? Missing a group by / unique check?

A single query that returns 50 frames will show 50 frames in that select all with the same refId

Bug
Screenshot from 2023-04-05 09-48-03

@torkelo torkelo requested review from a team as code owners April 5, 2023 07:50
@torkelo torkelo requested review from ivanortegaalba and kaydelaney and removed request for a team April 5, 2023 07:50
@torkelo torkelo added this to the 9.5.x milestone Apr 5, 2023
@torkelo torkelo requested a review from ryantxu April 5, 2023 07:51
@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pr-codeql-analysis-javascript.yml:analyze. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@torkelo
Copy link
Member Author

torkelo commented Apr 5, 2023

I pushed an update where I now show in the select only unique queries (refIds), and in the description I show the name of the frames (max 3)

Screenshot from 2023-04-05 10-16-21

@ryantxu ryantxu requested a review from a team as a code owner April 5, 2023 16:17
@ryantxu ryantxu requested review from tskarhed and ashharrison90 and removed request for a team April 5, 2023 16:17
@ryantxu
Copy link
Member

ryantxu commented Apr 5, 2023

@torkelo I pushed a change to this that moves the core logic to the @grafana/ui matcher... so it is also used in the field override picker
2023-04-05_09-23-48 (1)

Copy link
Member

@ryantxu ryantxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@torkelo ... approving, but you should check my work (mostly moving yours!)

Also, IIUC, this should not be backported -- it does not seem urgent enough to require the extra attention needed for that.

@torkelo
Copy link
Member Author

torkelo commented Apr 6, 2023

@ryantxu added a react testing lib unit test for the RefIDPicker component, feels like that logic should have tests :)

@torkelo torkelo merged commit e10ef22 into main Apr 7, 2023
15 checks passed
@torkelo torkelo deleted the transformation-filters branch April 7, 2023 06:31
@nmarrs nmarrs added no-backport Skip backport of PR and removed backport A backport PR labels Apr 11, 2023
@nmarrs nmarrs modified the milestones: 9.5.x, 10.0.0 Apr 11, 2023
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants